✨ Fine-grained logging control for flows #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Flow tests are all in one file. They mix together the tests for regular flows, logging, and flows in separate translation units. - GCC 12 has a constexpr bug that prevents flow steps from compiling. This is worked around in code, but ought to be called out in CMake. Solution: - Separate regular, separate TU, and logging tests for flows. - Control GCC 12 compilation in CMake.
Problem: - GCC 12 fails to compile flow nodes. Solution: - Persuade GCC that the run and log functions have linkage.
lukevalenty
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.